Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collections of Mixed #3441

Merged
merged 97 commits into from
Mar 7, 2024
Merged

Collections of Mixed #3441

merged 97 commits into from
Mar 7, 2024

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Sep 14, 2023 •
edited
Loading

Description

Add support for collections inside Mixed (RealmValue)

Fixes #3446

TODO

  • Changelog entry
  • Tests (if applicable)
  • Memory structure of RealmValue
  • Test/support for dynamic

@cla-bot cla-bot bot added the cla: yes label Sep 14, 2023
@papafe
Copy link
Contributor Author

papafe commented Sep 14, 2023

@nirinchev @fealebenpae I've created this PR just to get initial feedback on the approach for collections of mixed, mostly if the directions I'm taking so far makes sense. So it's all very rough, but there is one passing test at least 😁

@papafe
Copy link
Contributor Author

papafe commented Sep 22, 2023

The base for the implementation for list has been done:

  • Add list inside mixed
  • Add/Set/Insert list inside list
  • Corrected equality check
  • Modified realmValue

Missing:

  • Dynamic testing
  • Notifications

@papafe
Improved test and removed useless content
cda7a87
@papafe
Added tests
7727f37
@papafe
Small fixes
2fdefc7
@papafe
Small fixes
cdeaa4c
@papafe
Merge branch 'main' into fp/mixed-collections plus moved core to next…
943e6d9 
…-major

* main:
  Allow customizing json ignore attribute for serialized classes (#3451)
  Update README.md (#3450)
  Fix changelog
  Prepare for vNext (#3444)
  Prepare for 11.5.0 (#3442)
  Migrate to new sync error codes (#3440)
  Starting one cluster per platform on CI (#3426)
  Fix trailing comma when there are no features to analyze (#3438)

# Conflicts:
#	wrappers/realm-core
@papafe
Added common method for creating a list and adding elements
0c888ce
@papafe
Fixed error [skip-ci]
19f2167
@papafe
Added set and dictionary to primitive value
064a559
@papafe
Various improvements
9b75290
@papafe
Added conversion per list
87b7ce3
@papafe
Fixed Operator
4711912
@papafe
Added missing conversion methods
84fd027
@papafe
Corrected wrapper
acf2b82
@papafe
Merge remote-tracking branch 'refs/remotes/origin/fp/update-to-core-1…
b77685f 
…4' into fp/update-to-core-14
@papafe
Updated core to 14.0.1 and changelog
2e98c0a
@papafe
Added test for collection indexes
3db20b5
@papafe
Updated changelog
82c6b50
@papafe
Fixed realm studio version
ee596a5
@papafe
Updated guids to v24
ef0075e
@papafe
Corrected methods
26bfc48
@papafe
Corrected changelog and wrapper
28b8b88
@papafe
Added comments
2479b2a
@papafe
Corrected changelog
2a8e89e
@papafe
Corrected changelog
bf98fd4
@papafe
Updated core
2d04e61
@papafe
Updated changelog
b5d6e1d
@papafe
Merge branch 'main' into fp/mixed-collections
41effa6 
# Conflicts:
#	Tests/Realm.Tests/TestHelpers.cs
#	wrappers/realm-core
@papafe
Merge branch 'fp/update-to-core-14' into fp/mixed-collections
cc0e5aa 
# Conflicts:
#	Tests/Realm.Tests/EmbeddedResources/v6db.realm
#	wrappers/realm-core
@papafe
Used correct core version
b41a033
@papafe
Merge branch 'main' into fp/mixed-collections
1b346ca
@papafe
Fixed changelog
8149c89
@papafe
Fixed changelog
bfd027f
@papafe
Merge branch 'main' into fp/mixed-collections
cab3aae
@papafe
Added missing tests
69d0610
@papafe
Copy link
Contributor Author

papafe commented Mar 6, 2024

@nirinchev added missing tests for @count/@size/@type', ALL/ANY/NONE` and nested notifications. If the CI is green this is mergeable for me

nirinchev
nirinchev approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - there are 2 test failures on CI, but I'm not sure if those are flaky or something that is a result of these changes.

@papafe
Copy link
Contributor Author

papafe commented Mar 7, 2024

Looks good - there are 2 test failures on CI, but I'm not sure if those are flaky or something that is a result of these changes.

Flaky tests unfortunately.

@papafe
[RNET-1092] Added support for indexed RealmValue (#3544)
0d40c41 
* Added support for indexed RealmValue

* Fixed changelog

* Corrected indexable property types in schema

* Added missing newline in the changelog

* Testing fix for CI
@papafe papafe merged commit 7c25a1d into main Mar 7, 2024
65 of 66 checks passed
@papafe papafe deleted the fp/mixed-collections branch March 7, 2024 14:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

@fealebenpae fealebenpae Awaiting requested review from fealebenpae

Assignees

@papafe papafe

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structure RealmValue to occupy less memory
2 participants
@papafe @nirinchev