Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolgraph extension symbols #1372

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Symbolgraph extension symbols #1372

merged 2 commits into from
Oct 19, 2023

Conversation

johnfairh
Copy link
Collaborator

Support the opt-in symbolgraph extension symbols for Swift 5.9.

These are for extensions from other modules only, extensions in the same module don't get these symbols. I've turned on the option for the test case because it runs on Swift 5.9 and exercises all the new paths -- looks good, grabs a bunch more information for those extensions including doc comments.

@johnfairh
Copy link
Collaborator Author

johnfairh commented Oct 19, 2023

This all seems to work well.

Jazzy itself needs to support pre-5.9 swift so it does not set -emit-extension-block-symbols when asked to generate symbolgraphs itself. The user can override this if necessary as done in the test runner - we could be smarter I suppose.

Also fixes a couple of bugs:

  • typo prevented full declaration being propgated
  • set the module name correctly everywhere

Fixes #1368

@johnfairh johnfairh merged commit 5354fc0 into master Oct 19, 2023
5 checks passed
@johnfairh johnfairh deleted the jf-symgraph-extensions branch October 19, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant