Merge pull request #975 from realm/jf-bad-decl-xml

Do not crash with bad declaration XML

CHANGELOG.md

@@ -14,6 +14,10 @@
   [John Fairhurst](https://github.com/johnfairh)
   [#965](https://github.com/realm/jazzy/issues/965)
 
+* Fix crash with unicode scalars in string literals.  
+  [John Fairhurst](https://github.com/johnfairh)
+  [#972](https://github.com/realm/jazzy/issues/972)
+
 ## 0.9.3
 
 ##### Breaking

lib/jazzy/sourcekitten.rb

@@ -339,6 +339,8 @@ def self.make_doc_info(doc, declaration)
     def self.xml_to_text(xml)
       document = REXML::Document.new(xml)
       REXML::XPath.match(document.root, '//text()').map(&:value).join
+    rescue
+      ''
     end
 
     # Regexp to match an @attribute.  Complex to handle @available().
@@ -372,10 +374,11 @@ def self.split_decl_attributes(declaration)
     end
 
     def self.prefer_parsed_decl?(parsed, annotated)
-      parsed &&
-        (annotated.include?(' = default') || # SR-2608
-         parsed.match('@autoclosure|@escaping') || # SR-6321
-         parsed.include?("\n"))
+      annotated.empty? ||
+        parsed &&
+          (annotated.include?(' = default') || # SR-2608
+           parsed.match('@autoclosure|@escaping') || # SR-6321
+           parsed.include?("\n"))
     end
 
     # Replace the fully qualified name of a type with its base name