-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5461 added ib_segue_action case in TypeContent #5524
base: main
Are you sure you want to change the base?
#5461 added ib_segue_action case in TypeContent #5524
Conversation
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/TypeContentsOrderConfiguration.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This needs some tests. See TypeContentsOrderRuleTests
.
Also, you need to update the test reference for IntegrationTests.testDefaultConfigurations
to make the build pass.
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/TypeContentsOrderConfiguration.swift
Outdated
Show resolved
Hide resolved
Updated test reference in "default_rule_configurations" and removed "ibSegueAction" to avoid changing the defaults.
Hi, @SimplyDanny still the build is not passing, is there something else needed to be done? |
Now that you have removed the entry from the default list, the test reference update needs to be reverted. |
Hey @SimplyDanny. Now that the build has passed, is there anything else needs to be done or is it enough to merge and close the issue? |
|
Hey! I have added a new case to TypeContent enum for ib_segue_action. And also adapted the change in TypeContentsOrderRule.swift.