Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5461 added ib_segue_action case in TypeContent #5524

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dk-talks
Copy link

@dk-talks dk-talks commented Apr 2, 2024

Hey! I have added a new case to TypeContent enum for ib_segue_action. And also adapted the change in TypeContentsOrderRule.swift.

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 2, 2024

9 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:568:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:595:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/RootDebugViewController.swift:79:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'other_method' (type_contents_order)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/RootDebugViewController.swift:88:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'other_method' (type_contents_order)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/RootDebugViewController.swift:98:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'other_method' (type_contents_order)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:770:5: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:776:13: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
⚠️ This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/People/PeopleViewController.swift:188:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'type_method' (type_contents_order)
22 Messages
📖 Linting Aerial with this PR took 1.12s vs 1.13s on main (0% faster)
📖 Linting Alamofire with this PR took 1.64s vs 1.65s on main (0% faster)
📖 Linting Brave with this PR took 9.33s vs 9.48s on main (1% faster)
📖 Linting DuckDuckGo with this PR took 4.99s vs 5.11s on main (2% faster)
📖 Linting Firefox with this PR took 11.85s vs 11.9s on main (0% faster)
📖 Linting Kickstarter with this PR took 11.44s vs 11.48s on main (0% faster)
📖 Linting Moya with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.51s vs 3.52s on main (0% faster)
📖 Linting Nimble with this PR took 0.93s vs 0.93s on main (0% slower)
📖 Linting PocketCasts with this PR took 9.27s vs 9.19s on main (0% slower)
📖 Linting Quick with this PR took 0.42s vs 0.42s on main (0% slower)
📖 Linting Realm with this PR took 5.78s vs 5.73s on main (0% slower)
📖 Linting Sourcery with this PR took 2.88s vs 2.87s on main (0% slower)
📖 Linting Swift with this PR took 5.65s vs 5.72s on main (1% faster)
📖 Linting VLC with this PR took 1.52s vs 1.52s on main (0% slower)
📖 Linting Wire with this PR took 20.99s vs 21.08s on main (0% faster)
📖 Linting WordPress with this PR took 13.77s vs 13.8s on main (0% faster)
📖 This PR fixed a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:568:20: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
📖 This PR fixed a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:595:20: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
📖 This PR fixed a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:770:5: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
📖 This PR fixed a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:776:13: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/People/PeopleViewController.swift:188:20: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'type_method' (type_contents_order)

Here's an example of your CHANGELOG entry:

* #5461 added ib_segue_action case in TypeContent.  
  [dk-talks](https://github.com/dk-talks)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@dk-talks dk-talks closed this Apr 3, 2024
@dk-talks dk-talks deleted the dk-talks-add_TypeContent_ib_segue_action branch April 3, 2024 07:54
@dk-talks dk-talks restored the dk-talks-add_TypeContent_ib_segue_action branch April 3, 2024 07:56
@dk-talks dk-talks reopened this Apr 3, 2024
Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This needs some tests. See TypeContentsOrderRuleTests.

Also, you need to update the test reference for IntegrationTests.testDefaultConfigurations to make the build pass.

Updated test reference in "default_rule_configurations" and removed "ibSegueAction" to avoid changing the defaults.
@dk-talks
Copy link
Author

dk-talks commented Apr 9, 2024

Hi, @SimplyDanny still the build is not passing, is there something else needed to be done?

@SimplyDanny
Copy link
Collaborator

Hi, @SimplyDanny still the build is not passing, is there something else needed to be done?

Now that you have removed the entry from the default list, the test reference update needs to be reverted.

@dk-talks
Copy link
Author

dk-talks commented Apr 9, 2024

Hey @SimplyDanny. Now that the build has passed, is there anything else needs to be done or is it enough to merge and close the issue?

@SimplyDanny
Copy link
Collaborator

Hey @SimplyDanny. Now that the build has passed, is there anything else needs to be done or is it enough to merge and close the issue?

  1. This change needs tests. See TypeContentsOrderRuleTests.
  2. A changelog entry needs to be added. See CHANGELOG.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants