Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite vertical_whitespace rule using SwiftSyntax #5309

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

marcelofabri
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Oct 29, 2023

3 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
⚠️ This PR introduced a violation in Swift: /opt/homebrew/var/buildkite-agent/builds/SwiftLint-CI-4/swiftlint/swif
21 Messages
📖 Linting Aerial with this PR took 0.16s vs 0.27s on main (40% faster)
📖 Linting Alamofire with this PR took 0.09s vs 0.3s on main (70% faster)
📖 Linting Brave with this PR took 0.36s vs 1.71s on main (78% faster)
📖 Linting DuckDuckGo with this PR took 0.34s vs 0.9s on main (62% faster)
📖 Linting Firefox with this PR took 0.34s vs 1.63s on main (79% faster)
📖 Linting Kickstarter with this PR took 0.38s vs 1.81s on main (79% faster)
📖 Linting Moya with this PR took 0.14s vs 0.17s on main (17% faster)
📖 Linting NetNewsWire with this PR took 0.18s vs 0.65s on main (72% faster)
📖 Linting Nimble with this PR took 0.12s vs 0.23s on main (47% faster)
📖 Linting PocketCasts with this PR took 0.32s vs 1.55s on main (79% faster)
📖 Linting Quick with this PR took 0.09s vs 0.14s on main (35% faster)
📖 Linting Realm with this PR took 0.4s vs 1.07s on main (62% faster)
📖 Linting Sourcery with this PR took 0.23s vs 0.54s on main (57% faster)
📖 Linting Swift with this PR took 0.99s vs 1.23s on main (19% faster)
📖 Linting VLC with this PR took 0.14s vs 0.34s on main (58% faster)
📖 Linting Wire with this PR took 0.65s vs 3.82s on main (82% faster)
📖 Linting WordPress with this PR took 0.57s vs 2.58s on main (77% faster)
📖 This PR fixed a violation in Swift: /benchmark/single-source/StringWalk.swift:1289:1: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 4 (vertical_whitespace)
📖 This PR fixed a violation in Swift: /benchmark/single-source/StringWalk.swift:1304:1: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
📖 This PR fixed a violation in Swift: /benchmark/single-source/StringWalk.swift:1319:1: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
📖 This PR fixed a violation in Swift: /benchmark/single-source/StringWalk.swift:1378:1: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 4 (vertical_whitespace)

Here's an example of your CHANGELOG entry:

* Rewrite vertical_whitespace rule using SwiftSyntax.  
  [marcelofabri](https://github.com/marcelofabri)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants