Implement changes to support passing through raw query result rows #6
Conversation
This adds the same `body` method we added for SimpleQueryRow, but for Row this time.
The existing frontend::bind function does allow us to specify arbitrary result formats, but the query::encode_bind function calls it with a hardcoded result format of Some(1), which causes us to request binary format for all results. Since generic_query_raw is already part of our custom patchset that we've added on top of the upstream tokio-postgres code, I've modified this function to take result formats directly, and we can change the ReadySet code that uses this accordingly. Elsewhere, I've tried to avoid changing any existing APIs so as to make it easier to maintain this patch set in the future if we decide to merge in changes from upstream. As such, I've generally erred on the side of adding new functions that take the extra argument for result formats, and then retain the existing functions as-is and have them call the new function with the same hardcoded Some(1) value that retains the prior behavior.
|
I think I'm likely going to need to add one more commit to this PR, because if we want to add a new variant to |
|
Cool, thanks @dfwilbanks395! I ultimately decided it's better to eliminate the (I think we can also revert some of the derives we added in 9366b33 now that we don't need them for |
These two commits are necessary for passing through the raw data rows for proxied queries when using the Parse/Bind/Describe/Exec path (as opposed to the SimpleQuery path, where this kind of passthrough is already implemented).
The bulk of the necessary changes are to let us specify custom result formats when we execute a query, since we need to specify the same result formats as the original client query if we want the results we pass through to match what the client expects. We also add a public accessor for the underlying row data on the Row type. See the individual commit messages in this PR for more detail.
(For more context on why I'm making these changes, see readysettech/readyset#268).