feat(dotnet): masking #1074
Merged
feat(dotnet): masking #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gratcliff
reviewed
Sep 16, 2024
| return $"sha512-{base64Hash}?{opts}"; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@AndriiAndreiev looks like you're missing a couple end-of-file new lines. May want to update your IDE config!
gratcliff
reviewed
Sep 16, 2024
| @@ -16,12 +16,12 @@ cleanup-failure: | |||
| test-metrics-dotnet: ## Run Metrics tests against the .NET SDK | |||
| docker compose up --build --detach integration_dotnet_metrics_v6.0 | |||
| sleep 5 | |||
| npm run test:integration-metrics || make cleanup-failure | |||
| SUPPORTS_HASHING=true npm run test:integration-metrics || make cleanup-failure | |||
There was a problem hiding this comment.
Can we remove this flag and expect hashing across all of our integration suites, or are we still blocked by php?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Adds sensitive data masking to the Dotnet SDK
The logic is the same as we will have in Python SDK (PR #955)