Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift UI refactor opds catalog selector #497

Merged

Conversation

FuzzzzyBoy
Copy link
Contributor

@FuzzzzyBoy FuzzzzyBoy commented Oct 23, 2024

Another step for SwiftUI version TestApp

  • Bump the deployment target to iOS 15 to enable swipe actions in SwiftUI
  • Create SwiftUI version screen for OPDS catalogs
Screenshot 1 Screenshot 2

@FuzzzzyBoy
Copy link
Contributor Author

@mickael-menu Hi, can you check out this PR plz ?

@mickael-menu
Copy link
Member

Hi @FuzzzzyBoy I didn't forget about your PR, unfortunately I didn't have the time to check it out yet.

@FuzzzzyBoy
Copy link
Contributor Author

ok, thank for answer, I think may be I miss some rules for create PR :)

@FuzzzzyBoy
Copy link
Contributor Author

@mickael-menu think I fix all issues, can you check this MR one more time plz?

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FuzzzzyBoy!

@mickael-menu mickael-menu merged commit ac1f0ed into readium:develop Nov 4, 2024
5 of 6 checks passed
@FuzzzzyBoy FuzzzzyBoy deleted the SwiftUI-refactor-OPDSCatalogSelector branch November 4, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants