-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port API changes from the Kotlin toolkit #463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
force-pushed
the
refactoring-v3
branch
from
August 19, 2024 16:05
9e8c1ad
to
7a0c027
Compare
mickael-menu
force-pushed
the
refactoring-v3
branch
from
August 19, 2024 16:38
7a0c027
to
dfec043
Compare
mickael-menu
force-pushed
the
refactoring-v3
branch
from
August 20, 2024 12:52
63e1da8
to
68bdea7
Compare
mickael-menu
force-pushed
the
refactoring-v3
branch
from
August 20, 2024 13:08
68bdea7
to
940c60a
Compare
mickael-menu
added a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Shared
Format
type was introduced to augmentMediaType
with more precise information about the format specifications of anAsset
.Fetcher
was replaced with a simplerContainer
type.PublicationAsset
was replaced byAsset
, which contains aFormat
and access to the underlyingContainer
orResource
.ResourceError
hierarchy was revamped and simplified (seeReadError
). Now it is your responsibility to provide a localized user message for each error case.Streamer
Streamer
object was deprecated in favor of smaller segregated APIs:AssetRetriever
andPublicationOpener
.And much more...