Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am trying out the readium-lcp-server with our document server. It is nice to have a prepared Docker image for the server. I have created a simple Dockerfile to run both the lcp and lsd servers.
Some paths I had to use differ from the README (to make it more convenient in terms of mounting our own configuration, etc.).
Right now, both servers run under supervisord in a single container. I would like to also add targets for each server (so configuration without supervisord).
Let me know if you don't mind changes in some paths in README.md and
test/config.yaml
- I don't want to introduce redundant files that are just slightly different. Consider this PR as a draft right now. Thanks for the feedback.Interesting files:
compose.yml
- contains example configurationDockerfile
- Docker image definition.docker/config.yaml
- Default config.yaml used for both lcp and lsd. I would like to merge it withtest/config.yaml
after some changes