Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version flag and included HEAD commit hash into version string #76

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

nikinapi
Copy link
Contributor

@nikinapi nikinapi commented Feb 1, 2024

s7 version была абсолютно бесполезной, т.к. все значения были зашиты один раз и не менялись.
Добавил хеш HEAD, теперь ясно, с какого состояния она была собрана. Потенциально, это может помочь выявлять баги после апдейтов

@nikinapi nikinapi requested a review from pastey February 1, 2024 13:01
@nikinapi nikinapi self-assigned this Feb 1, 2024
Copy link
Contributor

@pastey pastey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я делал version исключительно в порыве open source. Пока клиентов кроме нас тут нет, хэш точно прекрасное решение. Спасибо!

@nikinapi nikinapi merged commit c777809 into main Feb 1, 2024
2 checks passed
@nikinapi nikinapi deleted the version-improvements branch February 1, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants