Merge pull request #28 from readdle/fix/swift-compiler-warning-in-gen…

…erated-code Fix swift compiler warnings in generated code
readdle · Jan 30, 2021 · c98b127 · c98b127
2 parents 0bb2199 + d1fd323
commit c98b127
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/compiler/src/main/java/com/readdle/codegen/SwiftFuncDescriptor.java b/compiler/src/main/java/com/readdle/codegen/SwiftFuncDescriptor.java
@@ -116,7 +116,21 @@ public void generateCode(SwiftWriter swiftWriter, String javaFullName, String sw
             swiftWriter.emitStatement(String.format("let %s: %s%s", param.name, param.swiftType.swiftType, param.isOptional ? "?" : ""));
         }
 
-        boolean shouldCatchPreamble = params.size() > 0 || !isStatic;
+
+        boolean shouldCatchPreamble = false;
+        if (isStatic) {
+            for (SwiftParamDescriptor param : params) {
+                // primitive types constructors not throw
+                if (param.isOptional || !param.isPrimitive()) {
+                    shouldCatchPreamble = true;
+                    break;
+                }
+            }
+        }
+        else {
+            shouldCatchPreamble = true;
+        }
+
         if (shouldCatchPreamble) {
             swiftWriter.emitStatement("do {");
         }