Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Task PEM-6766: prevent usage of private for macOS platform. #6

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

aishchenko-readdle
Copy link

@aishchenko-readdle aishchenko-readdle commented Jun 12, 2024

Ticket link

PEM-6766

Я все же решил воспользоваться советом @pastey и поменять на TARGET_OS_MAC.

PR submission checklist

  • PR name contains Jira ticket number
  • PR have correct target branch
  • .s7substat has correct subrepos revisions
  • Common (Obj-C / Swift) and your team's coding conventions and style guidelines are followed
  • Unit tests to cover the critical parts of the code are written
  • Relevant documentation updated / added if needed
  • Self-reviewed using the self-review checklist prior to submitting a PR
  • All recommendations from the How to create Pull Request document are followed

Copy link

@Naraian Naraian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TARGET_OS_MAC - элегантный способ послать код на 3 буквы, мне нравится ) Поломанные ПР чеки вроде не связаны с изменениями, надо брать.

@aishchenko-readdle aishchenko-readdle merged commit a728124 into master Jun 12, 2024
44 of 54 checks passed
@aishchenko-readdle aishchenko-readdle deleted the task/PEM-6766 branch June 12, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants