Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring flaky JCStress tests #3690

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Ignoring flaky JCStress tests #3690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
081e2e1
Ignoring flaky JCStress tests
chemicL Jan 3, 2024
8d0f999
License headers
chemicL Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions reactor-core/src/jcstress/java/reactor/core/publisher/FluxSwitchMapStressTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2022 VMware Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2021-2024 VMware Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -270,7 +270,8 @@ public void arbiter(II_Result r) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3633)
//@JCStressTest
@Outcome(id = {"200, 0", "200, 1"}, expect = ACCEPTABLE, desc = "Should produced exactly what was requested")
@State
public static class RequestAndProduceStressTest2 extends FluxSwitchMapStressTest {
Expand Down
11 changes: 7 additions & 4 deletions ...core/src/jcstress/java/reactor/core/publisher/FluxSwitchOnFirstConditionalStressTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2022 VMware Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2021-2024 VMware Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -56,7 +56,8 @@ public abstract class FluxSwitchOnFirstConditionalStressTest {
abstract Flux<String> switchOnFirst(Signal<? extends String> signal,
Flux<String> inbound);

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {"1, 1, 1, 1, 1"}, expect = ACCEPTABLE)
@State
public static class OutboundOnSubscribeAndRequestStressTest
Expand Down Expand Up @@ -95,7 +96,8 @@ public void arbiter(LLLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"1, 2, 0, 1"}, expect = ACCEPTABLE, desc = "inbound next with error happens first")
@Outcome(id = {
Expand Down Expand Up @@ -143,7 +145,8 @@ public void arbiter(LLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"1, 1, 2, 1, 1"}, expect = ACCEPTABLE, desc = "outbound cancel happened before inbound next")
@Outcome(id = {
Expand Down
32 changes: 21 additions & 11 deletions reactor-core/src/jcstress/java/reactor/core/publisher/FluxSwitchOnFirstStressTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2022 VMware Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2021-2024 VMware Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -57,7 +57,8 @@ public abstract class FluxSwitchOnFirstStressTest {
abstract Flux<String> switchOnFirst(Signal<? extends String> signal,
Flux<String> inbound);

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {"1, 1, 1, 1, 1"}, expect = ACCEPTABLE)
@State
public static class OutboundOnSubscribeAndRequestStressTest
Expand Down Expand Up @@ -96,7 +97,8 @@ public void arbiter(LLLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"0, 0, 1, 2, 2, 0, 1, 1, 0"}, expect = ACCEPTABLE, desc = "Inbound got second request, delivered onNext('value') and delivered onComplete() before cancellation")
@Outcome(id = {
Expand Down Expand Up @@ -168,7 +170,8 @@ public void arbiter(LLLLLLLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"0, 0, 1, 2, 2, 0, 2, 1, 0"}, expect = ACCEPTABLE, desc = "Inbound got second request, delivered onNext('value') and delivered onError() before cancellation")
@Outcome(id = {
Expand Down Expand Up @@ -241,7 +244,8 @@ public void arbiter(LLLLLLLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"1, 2, 0, 1"}, expect = ACCEPTABLE, desc = "inbound next with error happens first")
@Outcome(id = {
Expand Down Expand Up @@ -290,7 +294,8 @@ public void arbiter(LLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"0, 2, 0, 0"}, expect = ACCEPTABLE, desc = "inbound error with transformation error happens first")
@Outcome(id = {
Expand Down Expand Up @@ -340,7 +345,8 @@ public void arbiter(LLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"0, 2, 0, 0"}, expect = ACCEPTABLE, desc = "inbound complete with transformation error happens first")
@Outcome(id = {
Expand Down Expand Up @@ -390,7 +396,8 @@ public void arbiter(LLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"0, 0, 1, 2, 2, 1, 0, 1, 0"}, expect = ACCEPTABLE, desc = "inbound request happened first. then inbound cancel. then outbound cancel")
@Outcome(id = {
Expand Down Expand Up @@ -464,7 +471,8 @@ public void arbiter(LLLLLLLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"1, 1, 2, 1, 1"}, expect = ACCEPTABLE, desc = "outbound cancel happened before inbound next")
@Outcome(id = {
Expand Down Expand Up @@ -525,7 +533,8 @@ public void arbiter(LLLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"1, 0, 1, 1, 0"}, expect = ACCEPTABLE, desc = "inbound complete happened before outbound cancel")
@Outcome(id = {
Expand Down Expand Up @@ -586,7 +595,8 @@ public void arbiter(LLLLL_Result result) {
}
}

@JCStressTest
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
//@JCStressTest
@Outcome(id = {
"1, 0, 2, 1, 0"}, expect = ACCEPTABLE, desc = "inbound error happened before outbound cancel")
@Outcome(id = {
Expand Down
Loading