Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated receiveCommand for INT #568

Conversation

arushikesarwani94
Copy link
Contributor

@arushikesarwani94 arushikesarwani94 commented May 17, 2024

receiveCommand(@NonNull ReactPicker root, int commandId, @androidx.annotation.Nullable ReadableArray args)
for INT was deprecated 5 years ago in favour of
receiveCommand(@NonNull ReactPicker root, String commandId, @androidx.annotation.Nullable ReadableArray args)

This is needed to get rid of dispatchCommand INT variant here : https://github.com/facebook/react-native/blob/044aadbaf6830b21aab821804dc5a7989010022e/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java#L591-L595

The usages in @react-native-picker/picker are all dependent on String variant

@arushikesarwani94
Copy link
Contributor Author

cc: @Naturalclar for review

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, LGTm!

@Naturalclar Naturalclar merged commit 4ae337c into react-native-picker:master May 23, 2024
6 of 12 checks passed
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 2.7.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dgruseck
Copy link

@Naturalclar
Isn't this PR removing support for the focus and blur methods on Android?
For me the methods are not working anymore in 2.7.7 and 2.8.0

@Bhavik-P
Copy link

Bhavik-P commented Nov 1, 2024

@Naturalclar Isn't this PR removing support for the focus and blur methods on Android? For me the methods are not working anymore in 2.7.7 and 2.8.0

@Naturalclar This PR should definitely be reverted. This is causing the focus and blue methods to break making the ref purposeless.

@lucidtheory
Copy link

+1 can we fix this?

#423 (comment)

@arushikesarwani94
Copy link
Contributor Author

Are we not using the receiveCommand(@NonNull ReactPicker root, String commandId, @androidx.annotation.Nullable ReadableArray args) at all places ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants