Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Ruby versions when listing available definitions #631

Merged
merged 1 commit into from
Sep 8, 2014

Conversation

mislav
Copy link
Member

@mislav mislav commented Sep 8, 2014

Stable releases should now be sorted as a higher version than preview releases or RCs. For instance:

  • 1.9.3-preview < 1.9.3-rc1 < 1.9.3-p0
  • 2.1.0-dev < 2.1.0-rc1 < 2.1.0
  • jruby-1.7.0-preview1 < jruby-1.7.0-rc1 < jruby-1.7.0

Credit for the basis of this code goes to @mpapis and postmodern/chruby#277 (comment)

Closes #628, closes #512, #492

/cc @havenwood @nirvdrum

Stable releases should now be sorted as a higher version than preview
releases or RCs. For instance:

- 1.9.3-preview < 1.9.3-rc1 < 1.9.3-p0
- 2.1.0-dev < 2.1.0-rc1 < 2.1.0
- jruby-1.7.0-preview1 < jruby-1.7.0-rc1 < jruby-1.7.0
@mpapis
Copy link

mpapis commented Sep 8, 2014

nice trick with .z

mislav added a commit that referenced this pull request Sep 8, 2014
Sort Ruby versions when listing available definitions
@mislav mislav merged commit c2eb5e2 into master Sep 8, 2014
@mislav mislav deleted the sort-versions branch September 8, 2014 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants