Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type definition #405

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Update type definition #405

merged 6 commits into from
Apr 18, 2024

Conversation

ankitdas13
Copy link
Contributor

@ankitdas13 ankitdas13 commented Apr 18, 2024 •
edited
Loading

Update product & customer type-definition according to this doc

ip prop is optional in product requestProductConfiguration method :https://razorpay.com/docs/api/partners/product-configuration/request/
name prop is optional in customer create method : https://razorpay.com/docs/api/customers/create/

@ankitdas13 ankitdas13 changed the title Update type defination Update type definition Apr 18, 2024
Priyanshu-C
Priyanshu-C approved these changes Apr 18, 2024
View reviewed changes
Copy link

@Priyanshu-C Priyanshu-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM codewise, Don't have context of the requirement tho.

@ankitdas13 ankitdas13 added the TestingNotRequired TestingNotRequired label for BVT label Apr 18, 2024
@ankitdas13 ankitdas13 merged commit 14bbe97 into master Apr 18, 2024
14 checks passed
@OutdatedGuy OutdatedGuy mentioned this pull request May 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Priyanshu-C Priyanshu-C Priyanshu-C approved these changes

Assignees
No one assigned
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankitdas13 @Priyanshu-C