remove type check validation (#422)

razorpay · Oct 23, 2024 · 51cd366 · 51cd366
1 parent d836994
commit 51cd366
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/lib/resources/subscriptions.js b/lib/resources/subscriptions.js
@@ -246,12 +246,6 @@ module.exports = function subscriptionsApi (api) {
         return Promise.reject(MISSING_ID_ERROR);
       }
 
-      if (typeof cancelAtCycleEnd !== "boolean") {
-
-        return Promise.reject("The second parameter, Cancel at the end of cycle" +
-                              " should be a Boolean");
-      }
-
       return api.post({
         url,
         ...(cancelAtCycleEnd && {data: {cancel_at_cycle_end: 1}})

diff --git a/lib/types/subscriptions.d.ts b/lib/types/subscriptions.d.ts
@@ -356,11 +356,11 @@ declare function subscriptions(api: any): {
     * Cancel a subscription given id and optional cancelAtCycleEnd
     *
     * @param subscriptionId - The unique identifier of the Subscription.
-    * @param cancelAtCycleEnd - `false` (default): Cancel the subscription immediately.
+    * @param cancelAtCycleEnd - `false` or `0` (default): Cancel the subscription immediately.
     * 
     */
-    cancel(subscriptionId: string, cancelAtCycleEnd?: boolean): Promise<Subscriptions.RazorpaySubscription>
-    cancel(subscriptionId: string, cancelAtCycleEnd: boolean, callback: (err: INormalizeError | null, data: Subscriptions.RazorpaySubscription) => void): void;
+    cancel(subscriptionId: string, cancelAtCycleEnd?: boolean | number): Promise<Subscriptions.RazorpaySubscription>
+    cancel(subscriptionId: string, cancelAtCycleEnd: boolean| number, callback: (err: INormalizeError | null, data: Subscriptions.RazorpaySubscription) => void): void;
     /**
     * Delete offer linked to a subscription
     *