Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add ButtonGroup test cases #2068

Merged
merged 4 commits into from
Mar 19, 2024
Merged

test: add ButtonGroup test cases #2068

merged 4 commits into from
Mar 19, 2024

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 6, 2024 •
edited
Loading

Test cases for ButtonGroup.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fca7b9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rzpcibot
Copy link
Collaborator

rzpcibot commented Mar 6, 2024 •
edited
Loading

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
⬆ Accordion, AccordionItemHeader, AccordionItemBody, AccordionItem 7.331 7.351 +0.020 KB
⬆ ActionList, ActionListItem, ActionListItemBadge, ActionListItemBadgeGroup, ActionListItemIcon, ActionListItemText, ActionListSection 12.438 12.464 +0.026 KB
⬆ Alert 11.134 11.459 +0.325 KB
⬆ Amount 1.101 1.107 +0.006 KB
⬆ Badge 0.816 0.827 +0.011 KB
⬆ BladeProvider 1.649 1.655 +0.006 KB
⬆ BottomSheet 9.482 9.494 +0.012 KB
⬆ Box 0.751 0.762 +0.011 KB
⬆ Breadcrumb, BreadcrumbItem 2.526 2.536 +0.010 KB
⬆ Card, CardBody, CardHeader, CardHeaderIcon, CardHeaderIconButton, CardHeaderLeading, CardHeaderTrailing, CardFooter, CardFooterLeading, CardFooterTrailing 8.794 9.116 +0.322 KB
⬆ Carousel, CarouselItem 6.815 6.825 +0.010 KB
⬆ Checkbox 5.865 5.869 +0.004 KB
⬆ Chip, ChipGroup 5.333 5.350 +0.017 KB
⬆ Collapsible, CollapsibleLink, CollapsibleButton, CollapsibleBody 9.042 9.354 +0.312 KB
⬆ Counter 0.762 0.774 +0.012 KB
⬆ Divider 0.541 0.548 +0.007 KB
⬆ Drawer, DrawerBody, DrawerHeader 15.931 15.942 +0.011 KB
⬆ Dropdown, DropdownOverlay, DropdownButton, DropdownLink, DropdownFooter, DropdownHeader 22.345 22.656 +0.311 KB
⬆ FileUpload 13.245 13.261 +0.016 KB
⬆ Indicator 0.903 0.915 +0.012 KB
⬇ List, ListItem, ListItemLink, ListItemCode, ListItemText 5.055 5.053 -0.002 KB
⬆ Modal 12.568 12.569 +0.001 KB
⬆ Popover, PopoverInteractiveWrapper 20.315 20.326 +0.011 KB
⬆ ProgressBar 1.687 1.697 +0.010 KB
⬆ Radio 4.689 4.710 +0.021 KB
⬆ Skeleton 0.754 0.764 +0.010 KB
⬆ SpotlightPopoverTour, SpotlightPopoverTourFooter, SpotlightPopoverTourStep 27.921 28.237 +0.316 KB
⬆ Switch 4.550 4.563 +0.013 KB
⬆ Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions 49.983 50.294 +0.311 KB
⬆ Tabs, TabItem, TabList, TabPanel 6.599 6.604 +0.005 KB
⬆ Tag 3.409 3.425 +0.016 KB
⬆ ToastContainer, useToast 12.340 12.672 +0.332 KB
⬆ Tooltip, TooltipInteractiveWrapper 15.195 15.206 +0.011 KB
⬆ Button 5.589 5.921 +0.332 KB
⬆ IconButton 0.779 0.786 +0.007 KB
⬆ CheckboxGroup 3.971 3.981 +0.010 KB
⬆ SelectInput, AutoComplete 17.398 17.401 +0.003 KB
⬆ OTPInput 11.424 11.437 +0.013 KB
⬆ PasswordInput 13.539 13.547 +0.008 KB
⬇ TextArea 11.827 11.821 -0.006 KB
⬆ TextInput 13.419 13.428 +0.009 KB
⬆ Link 2.090 2.105 +0.015 KB
⬆ RadioGroup 3.948 3.957 +0.009 KB
⬆ Spinner 1.891 1.900 +0.009 KB
⬆ Code 0.604 0.610 +0.006 KB
⬆ Display 0.504 0.524 +0.020 KB
⬆ Heading 0.468 0.490 +0.022 KB
⬆ Text -0.001 0.002 +0.003 KB

Generated by 🚫 dangerJS against fca7b9b

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 6, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fca7b9b:

Sandbox Source
razorpay/blade: basic Configuration

@snitin315 snitin315 force-pushed the tests/button-group branch from bcc3fa9 to 6b21d18 Compare March 7, 2024 11:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@snitin315 snitin315 mentioned this pull request Mar 13, 2024
Merged
5 tasks
@snitin315 snitin315 force-pushed the tests/button-group branch from 6b21d18 to 3f8cbdf Compare March 13, 2024 06:18
@snitin315 snitin315 marked this pull request as ready for review March 13, 2024 06:29
@snitin315 snitin315 force-pushed the feat/add-button-group-component branch from f6291c1 to 206b1d3 Compare March 13, 2024 06:44
@snitin315 snitin315 force-pushed the tests/button-group branch from 3f8cbdf to 9e6363e Compare March 13, 2024 06:45
@snitin315 snitin315 added the Review - L1 First level of review label Mar 14, 2024
saurabhdaware
saurabhdaware reviewed Mar 18, 2024
View reviewed changes
packages/blade/src/components/ButtonGroup/__tests__/ButtonGroup.web.test.tsx
<Button>Three</Button>
</ButtonGroup>,
);
expect(container).toMatchSnapshot();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use .toHaveStyle to assert over specific style instead of full snapshot? lots of snapshots in this test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel snapshots are fine, Button tests also have a similar pattern.

anuraghazra
anuraghazra approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@anuraghazra anuraghazra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add Storybook kitchen sink for visual regression testing?

_KitchenSink.ButtonGroup.stories

@snitin315 snitin315 force-pushed the feat/add-button-group-component branch from 60fffb7 to 009523b Compare March 19, 2024 08:48
@snitin315 snitin315 force-pushed the tests/button-group branch from 9e6363e to fca7b9b Compare March 19, 2024 08:55
@snitin315
Copy link
Member Author

Can we add Storybook kitchen sink for visual regression testing?

_KitchenSink.ButtonGroup.stories

Have already added it in the implementation PR.

@snitin315 snitin315 merged commit eb5283b into feat/add-button-group-component Mar 19, 2024
15 of 17 checks passed
@snitin315 snitin315 deleted the tests/button-group branch March 19, 2024 09:06
snitin315 added a commit that referenced this pull request Mar 19, 2024
@snitin315
feat: add ButtonGroup component (#2064)
fd304e4 
 test: add ButtonGroup test cases (#2068)
anuraghazra pushed a commit that referenced this pull request Apr 9, 2024
@snitin315
feat: add ButtonGroup component (#2064)
25bc230 
 test: add ButtonGroup test cases (#2068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhdaware saurabhdaware saurabhdaware left review comments

@anuraghazra anuraghazra anuraghazra approved these changes

@chaitanyadeorukhkar chaitanyadeorukhkar Awaiting requested review from chaitanyadeorukhkar

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani

Assignees

@anuraghazra anuraghazra

Labels
Review - L1 First level of review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snitin315 @rzpcibot @saurabhdaware @anuraghazra