Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialect notifications #3

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

fsher
Copy link

@fsher fsher commented Apr 25, 2022

Adds dialect notifications, previous implementation deprecated.

Desktop:
Screen Shot 2022-04-25 at 18 15 07

Mobile:
Screen Shot 2022-04-25 at 17 58 50

@vercel
Copy link

vercel bot commented Apr 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
raydium-frontend ✅ Ready (Inspect) Visit Preview Apr 28, 2022 at 5:23PM (UTC)

@fsher
Copy link
Author

fsher commented Apr 25, 2022

Adding last changes (bumping versions/etc). Sorry about that.

@fsher fsher marked this pull request as ready for review April 25, 2022 14:16
@fsher fsher force-pushed the add-dialect-notifications branch from 099a3f3 to a2abdd1 Compare April 25, 2022 14:18
@fsher
Copy link
Author

fsher commented Apr 25, 2022

Hey, @TimonPeng! I'd appreciate your review on this one (for some reason, I can't seem to add reviewers, mb missing something, sorry about that)

@fsher
Copy link
Author

fsher commented Apr 25, 2022

Also, it seems that version update failed the vercel deployment (or mb something else). Please let me know what seems to be the problem there. Thanks!

@fsher
Copy link
Author

fsher commented Apr 28, 2022

@edsolater hey there! Thanks for you comment and feedback. I have to say that I really enjoyed working with the repo, you did an awesome job with store management and component structure.

We are working with your team offline to make this perfect and I'll follow up here again, once all comments have been addressed.

@zhelezkov
Copy link

please close this in favor of #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants