-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random-emoji command #977
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sixeight,
thanks for you contribution to our repository.
Give a check in my comments and re-request a review when you finish to address them.
# | ||
# Required parameters: | ||
# @raycast.schemaVersion 1 | ||
# @raycast.title random emoji |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Titles need to be capitalized
# @raycast.title random emoji | |
# @raycast.title Random Emoji |
# Required parameters: | ||
# @raycast.schemaVersion 1 | ||
# @raycast.title random emoji | ||
# @raycast.mode silent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make use of packageName
metadata ;)
# @raycast.mode silent | |
# @raycast.mode silent | |
# @raycast.packageName Emojis |
|
||
# Documentation: | ||
# @raycast.description Copy a random emoji to the clipboard. | ||
# @raycast.author Sixeight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# @raycast.author Sixeight | |
# @raycast.author Tomohiro Nishimura |
|
||
LANG="en_US.UTF-8" | ||
|
||
mapfile -t EMOJIS < <(curl -s https://raw.githubusercontent.com/github/gemoji/master/db/emoji.json | jq -r '.[] | .emoji') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you are making use of jq
and it doesn't come embedded in the OS, you need to specify it at the top of the file. Please, give a check in the contributing documentation
Description
Type of change
Screenshot
Dependencies / Requirements
Checklist