Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random-emoji command #977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sixeight
Copy link

Description

  • Choice emoji randomly and copy to clipboard.

Type of change

  • New script command
  • Bug fix
  • Improvement of an existing script
  • Documentation update
  • Toolkit change
  • Other (Specify)

Screenshot

CleanShot 2025-01-23 at 18 34 09

Dependencies / Requirements

Checklist

Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sixeight,
thanks for you contribution to our repository.

Give a check in my comments and re-request a review when you finish to address them.

#
# Required parameters:
# @raycast.schemaVersion 1
# @raycast.title random emoji
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Titles need to be capitalized

Suggested change
# @raycast.title random emoji
# @raycast.title Random Emoji

# Required parameters:
# @raycast.schemaVersion 1
# @raycast.title random emoji
# @raycast.mode silent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make use of packageName metadata ;)

Suggested change
# @raycast.mode silent
# @raycast.mode silent
# @raycast.packageName Emojis


# Documentation:
# @raycast.description Copy a random emoji to the clipboard.
# @raycast.author Sixeight
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @raycast.author Sixeight
# @raycast.author Tomohiro Nishimura


LANG="en_US.UTF-8"

mapfile -t EMOJIS < <(curl -s https://raw.githubusercontent.com/github/gemoji/master/db/emoji.json | jq -r '.[] | .emoji')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are making use of jq and it doesn't come embedded in the OS, you need to specify it at the top of the file. Please, give a check in the contributing documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants