Revert "Revert "[serve] Remove ability to specify route_prefix at deployment level" (#48292)"
#48294
+197
−1,047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
requested review from
zcin,
GeneDer,
akshay-anyscale and
a team
as code owners
8 tasks
edoakes
force-pushed
the
unrevert-route-prefix
branch
from
1d1b83c
to
89dd119
Compare
…eployment level" (ray-project#48292)" This reverts commit 703194a. Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
zcin
approved these changes
Oct 28, 2024
…vert-route-prefix
edoakes
force-pushed
the
unrevert-route-prefix
branch
from
5705151
to
42078f7
Compare
Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 703194a.
The original commit caused
test_deploy_2.pyto become flaky. It appears this was a timing issue due to the 10s timeout set on the test. I've removed this, as it looks like a very old test case that is no longer relevant.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.