-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] New API stack on by default for PPO. #48284
base: master
Are you sure you want to change the base?
[RLlib] New API stack on by default for PPO. #48284
Conversation
Signed-off-by: sven1977 <[email protected]>
…api_stack_on_by_default_ppo
Signed-off-by: sven1977 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Dumb question: If PPO is now new API stack by default, can't we just set this in the PPOConfig
instead of setting api_stack
to True
for enable_rl_module_and_learner
and enable_env_runner_and_connector_v2
?
@@ -22,6 +22,10 @@ | |||
|
|||
config = ( | |||
PPOConfig() | |||
.api_stack( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the hybrid stack is off?
…api_stack_on_by_default_ppo Signed-off-by: sven1977 <[email protected]> # Conflicts: # rllib/utils/exploration/tests/test_curiosity.py
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
New API stack on by default for PPO.
To switch back the old API stack, do:
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.