Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Modify max_concurrency in actor options to respect max_ongoing_requests (#47681) #48274

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

akyang-anyscale
Copy link
Contributor

Why are these changes needed?

This PR modifies the actor_options used when deploying replicas. Deployment will use the configured max_ongoing_requests attribute of the deployment config as the replica's max_concurrency if
the concurrency is not explicitly set. This is to prevent replica's max_concurrency from capping
max_ongoing_requests.

Related issue number

Closes #47681

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@akyang-anyscale akyang-anyscale changed the title [Serve] Modify max_concurrency in actor options to respect max_ongoing_requests (#47681) [Serve] Modify max_concurrency in actor options to respect max_ongoing_requests (https://github.com/ray-project/ray/issues/47681) Oct 25, 2024
@akyang-anyscale akyang-anyscale changed the title [Serve] Modify max_concurrency in actor options to respect max_ongoing_requests (https://github.com/ray-project/ray/issues/47681) [Serve] Modify max_concurrency in actor options to respect max_ongoing_requests (#47681) Oct 25, 2024
@akyang-anyscale akyang-anyscale force-pushed the alexyang/serve-max-ongoing-capped branch from f64fe8c to d4b81e3 Compare October 28, 2024 17:37
Signed-off-by: akyang-anyscale <[email protected]>
@akyang-anyscale akyang-anyscale added the go add ONLY when ready to merge, run all tests label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[serve] max_ongoing_requests limited by max_concurrency in actor
1 participant