Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kuberay operator addon to cmd in gke-gcs-bucket.md #48268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parnurzeal
Copy link

Without this option, the kubectl apply cmd won't work as it doesn't know the CRD.

Why are these changes needed?

The steps in the doc doesn't work. When trying a few times, found out that it misses the step to install kuberay operator.

Related issue number

Checks

NA for most as this is only adjusting a doc.

  • [ X ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ NA ] I've run scripts/format.sh to lint the changes in this PR.
  • [ NA ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ NA ] I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • [ NA ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ NA ] Unit tests
    • [ NA ] Release tests
    • [ NA ] This PR is not tested :(

Without this option, the `kubectl apply` cmd won't work as it doesn't know the CRD.

Signed-off-by: Theeraphol Wattanavekin <[email protected]>
@kevin85421
Copy link
Member

cc @andrewsykim would you mind reviewing this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants