Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Core] ray.get on a mixed list of dead and hanging tasks does not immediately raise ActorDiedError #48264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Oct 24, 2024

Why are these changes needed?

See the description in the corresponding issue for details.

Related issue number

Closes: #47204

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness force-pushed the bugfix/#47204-mix-dead-alive-actor-hang branch from 34e3c40 to 3494aaa Compare October 24, 2024 23:09
@MortalHappiness MortalHappiness changed the title WIP [Fix][Core] ray.get on a mixed list of dead and hanging tasks does not immediately raise ActorDiedError Oct 24, 2024
@MortalHappiness MortalHappiness force-pushed the bugfix/#47204-mix-dead-alive-actor-hang branch from 3494aaa to c4c988c Compare October 24, 2024 23:11
@MortalHappiness MortalHappiness marked this pull request as ready for review October 24, 2024 23:12
…t immediately raise ActorDiedError

Closes: ray-project#47204
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness MortalHappiness force-pushed the bugfix/#47204-mix-dead-alive-actor-hang branch from c4c988c to a2f042f Compare October 24, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] ray.get on a mixed list of dead and alive (but hanging) tasks does not immediately raise RayActorError
2 participants