-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Added object refs Task is dependent on to TaskInfoEntry
#48234
Changes from all commits
076681f
97702f0
c58418d
d3b9415
e9ec70b
41e668c
9293788
7065df6
0593974
1479420
b4a054b
2c50844
563c0e1
2f0c056
8ca9832
29659a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -637,6 +637,7 @@ CoreWorker::CoreWorker(const CoreWorkerOptions &options, const WorkerID &worker_ | |
[this] { | ||
RAY_LOG(INFO) << "Event stats:\n\n" | ||
<< io_service_.stats().StatsString() << "\n\n" | ||
<< task_execution_service_.stats().StatsString() << "\n\n" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Haha, I have another PR that also adds this. |
||
<< "-----------------\n" | ||
<< "Task Event stats:\n" | ||
<< task_event_buffer_->DebugString() << "\n"; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -589,6 +589,13 @@ message TaskInfoEntry { | |
// If the task/actor is created within a placement group, | ||
// this value is configured. | ||
optional bytes placement_group_id = 26; | ||
// Tasks arguments passed in as (object) references. | ||
// | ||
// NOTE: This list only contains `ObjectReference`s passed in as arguments | ||
// this task is dependent on and does NOT contain | ||
// - Args passed by value (inlined) | ||
// - ObjectRefs of the args passed by value | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this mean? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inlined objects |
||
repeated bytes args_object_ids = 27; | ||
} | ||
|
||
message Bundle { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we store the binary format of the object id instead of hex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decode in the API