http proxy sends sni servername #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that when a client connects to a
HttpProxy(during recording) using HTTPS and sends over a SNI host name, the proxy doesn't pass on the host name when it connects to the real server. As a result, the connection might fail if the server requires that a SNI host name be sent.We discovered this problem as we encountered this error message a bunch of times when recording washingtonpost.com:
This pull request tries to fix this problem. Although the code isn't well-written, Keith said we should send a pull request anyway.
-Wen (@zhangwen0411) and Ernest (@jxguan)