Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape {} into '' for non-standard filenames #51

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

adamant-pwn
Copy link
Contributor

No description provided.

@akahles
Copy link
Member

akahles commented Oct 29, 2024

Is there a test case for this?

@adamant-pwn
Copy link
Contributor Author

It got triggered on the file MLHC_lecture/project3/student_submissions/project3/cracra2019/MITBIH dataset/MITBIH - Models (1).ipynb, because it contains unescaped (1) in the filename. I didn't look into how tests are done in this particular project, but I suppose there isn't, since it failed 🤔

@akahles
Copy link
Member

akahles commented Oct 29, 2024

The tests are run as part of the CI using pytest. Would you mind having a look? If I remember correctly, there is some code generating some unicode filenames, testing some corner cases. Maybe this could be extended.

@adamant-pwn
Copy link
Contributor Author

I've updated the testcase to cover this, and also checked that it would fail without this change.

@akahles
Copy link
Member

akahles commented Nov 19, 2024

Thanks - LGTM

@akahles akahles merged commit 0f1ecfd into ratschlab:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants