Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: decrease image-version to 18.04 #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

actions: decrease image-version to 18.04 #17

wants to merge 1 commit into from

Conversation

rommelfreddy
Copy link
Contributor

No description provided.

@rommelfreddy
Copy link
Contributor Author

rommelfreddy commented Mar 1, 2021

this should be only a temporary change.
Maybe we should add phpstan and different php-versions to the image.

  • php 5.6
  • php 7.x
  • php 8.x

@eiriarte-mendez
Copy link
Contributor

Hi @rommelfreddy ,
hmm checks are still failing ...

Your requirements could not be resolved to an installable set of packages.

 Problem 1
   - phpunit/phpunit[5.7.0, ..., 5.7.27] require php ^5.6 || ^7.0 -> your php version (8.0.2) does not satisfy that requirement.
   - Root composer.json requires phpunit/phpunit 5.7.* -> satisfiable by phpunit/phpunit[5.7.0, ..., 5.7.27].

I think I will refactor the tests a bit and upgrade phpunit... but thx for trying ...

@eiriarte-mendez
Copy link
Contributor

this should be only a temporary change.
Maybe we should add phpstan and different php-versions to the image.

php 5.6
php 7.x
php 8.x

I will also try that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants