Check if pico-vscode.cmake file exists #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Bossman
commented
Sep 1, 2024
| f"include({cmakeIncPath()})\n" | ||
| f"set(picoVscode {cmakeIncPath()})\n" | ||
| "if (EXISTS ${picoVscode})\n" | ||
| " include(${picoVscode})\n" |
There was a problem hiding this comment.
@will-v-pi it would be nice to set the PICO_PLATFORM in the main CMakeLists.txt too as it allows projects that use riscv to be shared with others that do not have the extension installed.
There was a problem hiding this comment.
I think I'd prefer to stick to defaulting the pico platform based off the board (as the SDK does), and only changing it to Risc-V when using a Risc-V toolchain. For projects that require Risc-V and may have users not using the extension, they can add this to their CMakeLists.txt file to set the platform
if (NOT DEFINED PICO_PLATFORM)
set(PICO_PLATFORM rp2350-riscv CACHE STRING "Pico Platform")
endif()
will-v-pi
requested changes
Sep 2, 2024
Check if pico-vscode.cmake file exists to allow sharing vscode based projects with others that do not have the extension installed. Signed-off-by: Jesse Taube <[email protected]>
will-v-pi
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if pico-vscode.cmake file exists to allow sharing vscode based projects with others that do not have the extension installed.