Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configtxt/boot: Update arm_64bit flag #3903

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

tdewey-rpi
Copy link
Contributor

A casual reader might have previously assumed Raspberry Pi 5 requires this flag to boot in 64-bit mode. That is incorrect - Raspberry Pi 5 follows Raspberry Pi 4 in assuming 64-bit mode by default.

Edit the defaults line to reflect this, and further edit it to include more complete platform names.

A casual reader might have previously assumed Raspberry Pi 5 requires this flag to boot in 64-bit mode. That is incorrect - Raspberry Pi 5 follows Raspberry Pi 4 in assuming 64-bit mode by default.

Edit the defaults line to reflect this, and further edit it to include more complete platform names.
@@ -29,7 +29,7 @@ If set to 1, the kernel will be started in 64-bit mode. Setting to 0 selects 32-

In 64-bit mode, the firmware will choose an appropriate kernel (e.g. `kernel8.img`), unless there is an explicit `kernel` option defined, in which case that is used instead.

Defaults to 1 on Pi 4s (Pi 4B, Pi 400, CM4 and CM4S), and 0 on all other platforms. However, if the name given in an explicit `kernel` option matches one of the known kernels then `arm_64bit` will be set accordingly.
Defaults to 1 on Raspberry Pi 4, 5, 400 and Compute Module 4, 4S platforms. Defaults to 0 on all other platforms. However, if the name given in an explicit `kernel` option matches one of the known kernels then `arm_64bit` will be set accordingly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add CM5 as well - everyone knows its coming.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to avoid mentioning any potential products ahead of a formal announcement, especially if I've structured the text such that any new products could be trivially included in the line.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Tom in principle. But for my own edification: I assumed that CM5 wouldn't support 32-bit mode at all, just like Pi 5. So I don't think we need to add it here at release. Is that correct, @JamesH65 ? Or will CM5 support 32-bit mode?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's actually the SoC (and not the specific Model) that determines if it's capable of booting 32-bit kernel only (BCM2835, BCM2836), either 32- or 64-bit kernel (BCM2837, RP3A0, BCM2711), or 64-bit kernel only (BCM2712) ?

But (in general) we explicitly list the Models in documentation rather than SoCs, because people find it easier to identify their Model than to identify their SoC 🧦 😉

@lurch
Copy link
Contributor

lurch commented Nov 4, 2024

The NOTE block underneath this text also says "Raspberry Pi 5 only supports a 64-bit kernel, so this parameter has been removed for that device."

@tdewey-rpi
Copy link
Contributor Author

The NOTE block underneath this text also says "Raspberry Pi 5 only supports a 64-bit kernel, so this parameter has been removed for that device."

A fair note.

I'm not sure the best way to handle this, then - I'm fairly certain I don't like the disjointed-mentions around this flag, but perhaps it would be better served by trimming 5 from this change, and moving the note block above this paragraph?

@lurch
Copy link
Contributor

lurch commented Nov 4, 2024

I'm not sure the best way to handle this, then - I'm fairly certain I don't like the disjointed-mentions around this flag, but perhaps it would be better served by trimming 5 from this change, and moving the note block above this paragraph?

Might be worth splitting the Pi 5 info out of the current long NOTE block, and adding it as a separate NOTE block which appears earlier? 🤔

The Raspberry Pi 5 does not support the arm_64bit flag at all - and so users should be made aware that if they are reading the documentation in the context of Raspberry Pi 5 they are safe to skip the entire section.
@tdewey-rpi
Copy link
Contributor Author

The latest commit reflects my interpretation of @lurch's suggestion, but I've not seen prior evidence of NOTE blocks being at the start of the config item.

Accepted.

Co-authored-by: nate contino <[email protected]>
@tdewey-rpi
Copy link
Contributor Author

Thanks for the suggestion, @nathan-contino!

Accepted.

Co-authored-by: nate contino <[email protected]>
Copy link
Collaborator

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for waiting a bit on this. I knew there was a better way to present the info, but I had to chew on it for a little while. I think we're in a much better place now with this change.

Now, to propagate these ideas into the other config.txt entries 😉

@nathan-contino nathan-contino merged commit 9db62d6 into develop Nov 7, 2024
1 check passed
@nathan-contino nathan-contino deleted the dev/tdewey/config/boot/arm_64bit branch November 7, 2024 15:16
Comment on lines +37 to +38
* uncompressed image files
* gzip archives of an image
Copy link
Contributor

@lurch lurch Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should remove the plural from these two lines, given that you'll only ever be using one kernel at any given time? And IMHO "archive" usually implies that there's more than one file inside the archive, so perhaps this could be simplified too? (so "uncompressed image file" and "gzip-compressed image file" ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants