Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Connect documentation for 2.0 #3887

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Update Connect documentation for 2.0 #3887

merged 3 commits into from
Oct 25, 2024

Conversation

mudge
Copy link
Contributor

@mudge mudge commented Oct 17, 2024

Specifically:

  • Update the documentation for the new wfpanel plugin which replaces the built-in user interface
  • Update all screenshots with the latest Connect website
  • Prefer the new rpi-connect on and rpi-connect off commands instead of using systemctl directly
  • Promote the troubleshooting tips posted to the forums to the official documentation

Note that the new user interface is a plugin for wfpanel which is separate from the "system tray" so switch to referring to the new icon as being "in the menu bar" to avoid any ambiguity.

@nathan-contino nathan-contino marked this pull request as draft October 17, 2024 11:41
@nathan-contino
Copy link
Collaborator

Converting to draft since we're not ready to roll it out yet. But I'll get copy editing shortly!

@mudge mudge force-pushed the connect-2.0 branch 2 times, most recently from 1b41037 to d1e8db4 Compare October 17, 2024 14:56
Specifically:

* Update the documentation for the new wfpanel plugin which replaces the
  built-in user interface
* Update all screenshots with the latest Connect website
* Prefer the new rpi-connect on, rpi-connect off, and rpi-connect
  restart commands instead of using systemctl directly
* Remove instructions to manually restart after upgrade as this will now
  be done automatically
* Promote the troubleshooting tips posted to the forums to the official
  documentation

Note that the new user interface is a plugin for wfpanel which is
separate from the "system tray" so switch to referring to the new icon
as being "in the menu bar" to avoid any ambiguity.
As neither rpi-connect 1.4.0 nor rpi-connect-lite 1.4.0 clean up their
systemd symlinks or stop their services on uninstall, it is important
that users upgrade from rpi-connect 1.4.0 to rpi-connect 2.0.0 or they
upgrade from rpi-connect-lite 1.4.0 to rpi-connect-lite 2.0.0.

If they attempt to switch packages during the upgrade (i.e. go from
rpi-connect 1.4.0 to rpi-connect-lite 2.0.0 or from rpi-connect-lite
1.4.0 to rpi-connect 2.0.0), the necessary migration script will not run
leaving them in an inconsistent state until they either purge their old
package or upgrade it.

Document this issue by encouraging users to upgrade their existing
package in place before any attempt to switch between rpi-connect and
rpi-connect-lite.
@nathan-contino nathan-contino marked this pull request as ready for review October 25, 2024 20:33
Copy link
Collaborator

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor style guide and undocumented style improvements. Thanks so much for putting in the hard work here!

documentation/asciidoc/services/connect/install.adoc Outdated Show resolved Hide resolved
documentation/asciidoc/services/connect/use.adoc Outdated Show resolved Hide resolved
documentation/asciidoc/services/connect/use.adoc Outdated Show resolved Hide resolved
documentation/asciidoc/services/connect/use.adoc Outdated Show resolved Hide resolved
@nathan-contino nathan-contino merged commit a395576 into develop Oct 25, 2024
1 check passed
@nathan-contino nathan-contino deleted the connect-2.0 branch October 25, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants