-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing ruby version requirement from README #3045
Conversation
So for Homebrew I'm (fairly) sure that the version number for Ruby isn't needed if (and only if) you install the default version. We only needed the version number in there because we were forced to install 2.7. Unfortunately, I can't check right now. Need a clean laptop, which isn't gonna happen till next week. |
@nelliemckesson I guess you need to edit line 58 too 😉 |
Could possibly because I use ruby-install and chruby instead of doing things the simple way with just Homebrew, but I noticed after installing the toolchain on my work laptop I didn't have to edit my ~/.zshrc file to include any of the PATH or environment variables. Also does the line 60 callout of Homebrew not liking zsh still true? I've yet to have an issue with it. |
I can't actually remember what the problem was. Might have been Honebrew rather than Ruby. Or rather a Ruby related Homebrew problem. Guess I'm going to have to get a fresh from the factory Mac and do an install if you've gone off piste and not gone via the Homebrew route. |
…on & zsh defaults
Updated the README based on my installation experience -- as far as I can tell, you don't need to specify a version for the Ruby bundler OR Ruby itself, the latest should be fine for both. Works on my machine, FWIW. Took the opportunity to clean up some lengthy and difficult-to-verify configuration, instead providing a complete solution for the most common case -- Apple Silicon & the default And also broke up some multi-command blocks into individual copyable commands, and added links to the packages being manually installed so folks aren't (quite so) blindly installing software on their machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
And finally, install the [YAML module for Python 3](https://formulae.brew.sh/formula/pyyaml#default): | ||
|
||
``` | ||
$ pip3 install pyyaml | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this doesn't need to be here, because pyyaml
gets installed anyway by the
pip3 install --user -r requirements.txt
command that we run later? (see https://github.com/raspberrypi/documentation/blob/develop/requirements.txt )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works the way it's written, then it's fine.
@aallan @lurch I wasn't quite sure how to handle the various references to the ruby version folder. Feel free to throw this away if you have a better way to denote that.