Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ruby version requirement from README #3045

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Removing ruby version requirement from README #3045

merged 2 commits into from
Sep 4, 2023

Conversation

nelliemckesson
Copy link
Contributor

@aallan @lurch I wasn't quite sure how to handle the various references to the ruby version folder. Feel free to throw this away if you have a better way to denote that.

@aallan
Copy link
Contributor

aallan commented Aug 10, 2023

So for Homebrew I'm (fairly) sure that the version number for Ruby isn't needed if (and only if) you install the default version. We only needed the version number in there because we were forced to install 2.7. Unfortunately, I can't check right now. Need a clean laptop, which isn't gonna happen till next week.

@aallan aallan linked an issue Aug 10, 2023 that may be closed by this pull request
@lurch
Copy link
Contributor

lurch commented Aug 11, 2023

@nelliemckesson I guess you need to edit line 58 too 😉

@jehlers42
Copy link
Contributor

Could possibly because I use ruby-install and chruby instead of doing things the simple way with just Homebrew, but I noticed after installing the toolchain on my work laptop I didn't have to edit my ~/.zshrc file to include any of the PATH or environment variables.

Also does the line 60 callout of Homebrew not liking zsh still true? I've yet to have an issue with it.

@aallan
Copy link
Contributor

aallan commented Aug 21, 2023

I can't actually remember what the problem was. Might have been Honebrew rather than Ruby. Or rather a Ruby related Homebrew problem. Guess I'm going to have to get a fresh from the factory Mac and do an install if you've gone off piste and not gone via the Homebrew route.

@nathan-contino
Copy link
Collaborator

nathan-contino commented Sep 4, 2023

Updated the README based on my installation experience -- as far as I can tell, you don't need to specify a version for the Ruby bundler OR Ruby itself, the latest should be fine for both. Works on my machine, FWIW.

Took the opportunity to clean up some lengthy and difficult-to-verify configuration, instead providing a complete solution for the most common case -- Apple Silicon & the default zsh shell -- and providing some pointers for folks with nonstandard environments like bash and Intel processors.

And also broke up some multi-command blocks into individual copyable commands, and added links to the packages being manually installed so folks aren't (quite so) blindly installing software on their machine.

Copy link
Contributor

@aallan aallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aallan aallan merged commit acf2c04 into develop Sep 4, 2023
1 check passed
@aallan aallan deleted the iss-3037 branch September 4, 2023 18:49
README.md Show resolved Hide resolved
Comment on lines +110 to 114
And finally, install the [YAML module for Python 3](https://formulae.brew.sh/formula/pyyaml#default):

```
$ pip3 install pyyaml
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't need to be here, because pyyaml gets installed anyway by the

pip3 install --user -r requirements.txt

command that we run later? (see https://github.com/raspberrypi/documentation/blob/develop/requirements.txt )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works the way it's written, then it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 2.7 still needed?
5 participants