Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change credentials path to offer #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mhrynenko
Copy link
Contributor

No description provided.

@mhrynenko mhrynenko requested a review from freigeistig May 8, 2024 15:10
@mhrynenko mhrynenko self-assigned this May 8, 2024
api_ui/api.yaml Outdated
@@ -394,7 +394,7 @@ paths:
'500':
$ref: '#/components/responses/500'

/v1/credentials/{claim-id}:
/v1/offer/{claim-id}:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to name as credentials/{claim-id}/offer. But in order not to make request for mobile apps review again, just wait for new updates from their side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant