Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Switch to use new Python bindings from cuda-python/cuda-bindings #111

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: Switch to use new Python bindings from cuda-python/cuda-bindings #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41ef0ac
switch to use new bindings
leofang Oct 29, 2024
2c362d0
update test_patch.py
leofang Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,7 @@ cmake_minimum_required(VERSION 3.26.4 FATAL_ERROR)
project(
pynvjitlink
VERSION ${SKBUILD_PROJECT_VERSION}
LANGUAGES CXX CUDA
LANGUAGES CXX
)
Comment on lines 5 to 9
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this PR turns pynvjitlink into a pure Python package (I think!), I don't really know what to put here, given that I've never used CMake to package a pure Python project... 😆

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to involve CMake for a pure Python package. Probably only a pyproject.toml would be necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we would need to rearchitect the build systems and CI scripts to account for having only a single build of a pure Python package.


find_package(Python COMPONENTS Interpreter Development REQUIRED)

Python_add_library(_nvjitlinklib MODULE pynvjitlink/_nvjitlinklib.cpp WITH_SOABI)

find_package(
# Require CUDA 12.2 Update 2 to avoid nvjitlink bugs
CUDAToolkit 12.2.140 REQUIRED
)
target_link_libraries(_nvjitlinklib PRIVATE CUDA::nvJitLink_static CUDA::nvptxcompiler_static)

target_compile_options(_nvjitlinklib PRIVATE -Werror -Wall)

target_compile_features(_nvjitlinklib PRIVATE cxx_std_11)

install(TARGETS _nvjitlinklib LIBRARY DESTINATION pynvjitlink)
368 changes: 0 additions & 368 deletions pynvjitlink/_nvjitlinklib.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading