Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a __dataframe__ method to the protocol dataframe object #11692

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

rgommers
Copy link
Contributor

This will align the implementation with those in other libraries, xref data-apis/dataframe-api#80.

Cc @shwina

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rgommers rgommers requested a review from a team as a code owner September 13, 2022 13:14
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@shwina
Copy link
Contributor

shwina commented Sep 13, 2022

ok to test

@shwina shwina added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 13, 2022
@raydouglass
Copy link
Member

ok to test

This will align the implementation with those in other libraries,
xref data-apis/dataframe-api#80.
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 86.39% // Head: 86.42% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (55819dc) compared to base (7b0d597).
Patch coverage: 75.00% of modified lines in pull request are covered.

❗ Current head 55819dc differs from pull request most recent head 01e0607. Consider uploading reports for the commit 01e0607 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.10   #11692      +/-   ##
================================================
+ Coverage         86.39%   86.42%   +0.02%     
================================================
  Files               145      145              
  Lines             23014    23016       +2     
================================================
+ Hits              19883    19891       +8     
+ Misses             3131     3125       -6     
Impacted Files Coverage Δ
python/cudf/cudf/io/orc.py 93.02% <ø> (ø)
python/cudf/cudf/io/parquet.py 90.83% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
python/cudf/cudf/core/df_protocol.py 88.17% <50.00%> (-0.28%) ⬇️
python/cudf/cudf/core/dataframe.py 93.77% <100.00%> (+0.04%) ⬆️
python/dask_cudf/dask_cudf/io/orc.py 91.04% <100.00%> (ø)
python/cudf/cudf/core/column/string.py 88.53% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.22% <0.00%> (+0.21%) ⬆️
python/cudf/cudf/core/column/numerical.py 95.90% <0.00%> (+0.29%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shwina
Copy link
Contributor

shwina commented Sep 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 02d5e83 into rapidsai:branch-22.10 Sep 21, 2022
@rgommers rgommers deleted the add-dunder-dataframe branch September 21, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants