Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicef logo bug #1062

Open
pauloabreu opened this issue Apr 12, 2022 · 3 comments
Open

Unicef logo bug #1062

pauloabreu opened this issue Apr 12, 2022 · 3 comments

Comments

@pauloabreu
Copy link
Contributor

pauloabreu commented Apr 12, 2022

Resume

The Unicef logo in footer are breaking in some server because slashes in url:

/sitestatic//img/UNICEF_footer_Logo_black_en.png <- Broken
/sitestatic/img/UNICEF_footer_Logo_black_en.png <- Working

HAML:

%img.-ml-2(src="{{STATIC_URL}} / img/UNICEF_footer_Logo_black_en.png" class="md:-ml-0")
but {{STATIC_URL}} already have a slash, resulting in /sitestatic//img/UNICEF_footer

The Nyaruka code:

in other cases we can see this pattern: %img(src="{{STATIC_URL}}img/u-report-global-logo-white.png"), which works fine.

Reference

templates/public_base.haml:621
templates/public_base.haml:623
templates/public_base.haml:635 
templates/public_base.haml:637
ureport/settings_common.py:144
@matmsa27
Copy link
Contributor

HI @norkans7, can you help us about this?

@norkans7
Copy link
Contributor

I think you can make a PR with the fixes

@matmsa27
Copy link
Contributor

Nice, we will open. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants