Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unicef logo #164

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix Unicef logo #164

merged 1 commit into from
Apr 20, 2022

Conversation

pauloabreu
Copy link

Resume

The Unicef logo in footer are breaking in some server because slashes in url:

/sitestatic//img/UNICEF_footer_Logo_black_en.png <- Broken
/sitestatic/img/UNICEF_footer_Logo_black_en.png <- Working

HAML:

%img.-ml-2(src="{{STATIC_URL}} / img/UNICEF_footer_Logo_black_en.png" class="md:-ml-0")
but {{STATIC_URL}} already have a slash, resulting in /sitestatic//img/UNICEF_footer

The Nyaruka code:

in other cases we can see this pattern: %img(src="{{STATIC_URL}}img/u-report-global-logo-white.png"), which works fine.

Reference

templates/public_base.haml:621
templates/public_base.haml:623
templates/public_base.haml:635 
templates/public_base.haml:637
ureport/settings_common.py:144

Issue: rapidpro#1062

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #164 (cf15fc6) into main (d4dc0f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files          44       44           
  Lines        4683     4683           
=======================================
  Hits         3834     3834           
  Misses        849      849           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4dc0f3...cf15fc6. Read the comment docs.

@pauloabreu pauloabreu merged commit 98ec68f into main Apr 20, 2022
@pauloabreu pauloabreu deleted the fix/unicef-logo branch April 20, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants