Reline behind a feature flag #19559
Open
Reline behind a feature flag #19559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanusz-r7
force-pushed
the
readline-to-reline-behind-feature-flag
branch
8 times, most recently
from
1f24c46
to
879750b
Compare
sjanusz-r7
changed the title
sjanusz-r7
force-pushed
the
readline-to-reline-behind-feature-flag
branch
2 times, most recently
from
7753956
to
6fb1316
Compare
sjanusz-r7
force-pushed
the
readline-to-reline-behind-feature-flag
branch
from
6fb1316
to
d2b887e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #19397
This PR adds in the usage of the Reline library behind a feature flag.
Reline currently has some bugs/issues/inconsistencies compared to Readline. These are tracked as issue reports on Reline's GitHub.
These include:
We are moving away from Readline in favor if a pure Ruby implementation.
We are having to remove Readline on newer Windows 11 hosts due to an issue that Reline also encountered (and fixed since), where the console output handle would sometimes be incorrect, likely after calling popen, thus calls to console APIs such as
SetConsoleCursorPositionwould fail. A workaround is to periodically refresh the handle variable by callinghandle = GetStdHandle.call(-11) // for STDOUT.Verification