Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbon Black Cloud] Fix 404 job id response #2962

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

nmccullagh-r7
Copy link
Collaborator

Proposed Changes

Description

Fix error handling for 404 responses from carbon_black_cloud

@nmccullagh-r7 nmccullagh-r7 force-pushed the fix-404-job-id-response branch from 95f462d to 21c9d81 Compare November 18, 2024 11:48
@nmccullagh-r7 nmccullagh-r7 changed the base branch from master to develop November 18, 2024 11:49
@nmccullagh-r7 nmccullagh-r7 force-pushed the fix-404-job-id-response branch from 21c9d81 to 0e4baf7 Compare November 18, 2024 11:52
@nmccullagh-r7 nmccullagh-r7 force-pushed the fix-404-job-id-response branch from 0e4baf7 to dddaf17 Compare November 18, 2024 11:54
Copy link
Collaborator

@joneill-r7 joneill-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just one comment around the assertion in the unit test

@nmccullagh-r7 nmccullagh-r7 merged commit 859f48d into develop Nov 18, 2024
10 checks passed
@nmccullagh-r7 nmccullagh-r7 deleted the fix-404-job-id-response branch November 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants