[Palo Alto] Error 401 correctly #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmccullagh-r7
force-pushed
the
error-401-correctly
branch
2 times, most recently
from
23f6bbf to
e5a50dc
Compare
nmccullagh-r7
force-pushed
the
error-401-correctly
branch
4 times, most recently
from
0789168 to
02fafbc
Compare
ekelly-r7
reviewed
Nov 8, 2024
plugins/palo_alto_cortex_xdr/icon_palo_alto_cortex_xdr/tasks/monitor_alerts/task.py
Show resolved
Hide resolved
ekelly-r7
reviewed
Nov 8, 2024
plugins/palo_alto_cortex_xdr/unit_test/test_get_file_quarantine_status.py
Outdated
Show resolved
Hide resolved
nmccullagh-r7
force-pushed
the
error-401-correctly
branch
from
02fafbc to
cf81db2
Compare
ekelly-r7
approved these changes
Nov 8, 2024
ekelly-r7
reviewed
Nov 8, 2024
|
|
||
| new_headers = self._advanced_authentication(api_key=self.api_key, api_key_id=self.api_key_id) | ||
| new_response = self.build_request(url=url, headers=new_headers, post_body=post_body) | ||
|
|
||
| if new_response.status_code in [401, 403]: | ||
| self.logger.info("Token is still invalid, raising exception") |
There was a problem hiding this comment.
np: I think should be self.logger.error
joneill-r7
approved these changes
Nov 8, 2024
nmccullagh-r7
added a commit
that referenced
this pull request
Nov 11, 2024
nmccullagh-r7
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
https://rapid7.atlassian.net/browse/SOAR-18176
Description