Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tab numbers in CollapsedTab layout #593

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

diwasrimal
Copy link

No description provided.

@raphamorim
Copy link
Owner

That's great, thanks for the PR @diwasrimal. I haven't tested locally yet but I want to ask if is possible to add this feature behind a configuration property?

Maybe:

[navigation]
display-tab-number = true

@diwasrimal
Copy link
Author

Other modes like TopTab, BottomTab and Breadcrumb already show tab numbers by default so I think you can just make it default to show numbering for CollapasedTab too. Using a single configuration variable like display-tab-number that handles showing number for all modes is good too. For me, this would take a lot of time since I'm not so comfortable with rust.

@raphamorim
Copy link
Owner

Using a single configuration variable like display-tab-number that handles showing number for all modes is good too

yes, that’s what I meant, sorry if I wasn’t clear 🙏

The problem of implementing numbers for collapsed tabs by default is that many users like the way it’s (without much details) so might been conflicting with them as well.

For me, this would take a lot of time since I'm not so comfortable with rust.

there’s no rush! Take your time and feel free to ping me on discord as well. I can help pointing in the code 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants