Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "WIP: When friendly dates are enabled, group elements use frie… #737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcarstairs-scottlogic
Copy link
Contributor

This reverts commit c3fceea.

This PR is still WIP, so we should revert it for now

@jcarstairs-scottlogic
Copy link
Contributor Author

jcarstairs-scottlogic commented Sep 13, 2024

The finished PR is nearly ready. Sorry for the long wait, I had other professional priorities at work.

I only need to localise two new translation keys. I don't know most of the languages, so I'm going to do my best with machine translation tools and/or dictionaries - let me know if you have a better approach @ransome1 !

@ransome1
Copy link
Owner

@jcarstairs-scottlogic I´m exited :) My experiences using chatGPT for the translations have been very positive. And if something really is wrong, it often is pointed out by some users.

@jcarstairs-scottlogic
Copy link
Contributor Author

The finished PR is ready for review @ransome1 :))

You probably want to merge this first though, or the diff will be impossible to understand. Once this is merged, the final PR should automatically update to point at ransome1/master.

@jcarstairs-scottlogic
Copy link
Contributor Author

Sorry this has taken ages. I have started a new project at work and haven't had as much time for open-source contributions :))

@ransome1
Copy link
Owner

ransome1 commented Oct 2, 2024

@jcarstairs-scottlogic I havn't yet found the time to look at it. Unfortunately I am having some complications get getting the application up and running after a major change in one of the dependencies. I'll let you know once sleek is up and I was able to review the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants