Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable v3 migration by default #979

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

alexander-demicev
Copy link
Member

@alexander-demicev alexander-demicev commented Jan 6, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #978
Fixes #930

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

anmazzotti
anmazzotti previously approved these changes Jan 7, 2025
furkatgofurov7
furkatgofurov7 previously approved these changes Jan 7, 2025
@furkatgofurov7 furkatgofurov7 enabled auto-merge (squash) January 7, 2025 09:16
@furkatgofurov7
Copy link
Contributor

I am not sure why required lint-test job have not run on this PR automatically which blocks the merge.

salasberryfin
salasberryfin previously approved these changes Jan 8, 2025
@alexander-demicev alexander-demicev changed the title Enable v3 migration by default [wip] Enable v3 migration by default Jan 8, 2025
@alexander-demicev alexander-demicev force-pushed the enablev3migration branch 4 times, most recently from 241a84c to 1028710 Compare January 14, 2025 09:32
@alexander-demicev alexander-demicev changed the title [wip] Enable v3 migration by default Enable v3 migration by default Jan 14, 2025
Signed-off-by: Alexandr Demicev <[email protected]>
Signed-off-by: Alexandr Demicev <[email protected]>
@alexander-demicev alexander-demicev merged commit ccab7e0 into rancher:main Jan 14, 2025
9 checks passed
@alexander-demicev alexander-demicev deleted the enablev3migration branch January 14, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Enable v3 migration by default [e2e] Ngrok setup chartmuseum - invalid certificate
5 participants