Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign header area #514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gordlin
Copy link
Member

@gordlin gordlin commented Jan 17, 2025

DEPENDS ON #510 (this branch is based on that branch). Pull that first!

Related Item(s)

Issue #504

Changes

  • [FEATURE] Implements the UI/UX team's Figma suggestions for the header, with a few extra changes.
    • Header now has two layers: The "upper header", containing the Leave editor button and all the save-related UI elements (unsaved changes warning, reset changes button, save button); and the "lower header", containing the product title/UUID and all other buttons (preview, download, etc.)
    • Share feedback button moved to lower header.
    • Redesigned unsaved changes warning and reset changes button.
    • Add icons to save and preview buttons.
    • Save and reset changes buttons will now be disabled until there are unsaved changes.
    • Added an editor language toggle in the upper header, which will only show up when not on the Canada.ca template.
    • Set title and UUID to truncate at one line, to prevent wrapping.
    • Add tooltips to all header elements. These can also be accessed on mobile by holding the element for 500ms.
    • On mobile display sizes, header is now sticky and most buttons have their text hidden (only icons).

Notes

Header, desktop, no unsaved changes:
image

Header, desktop, with unsaved changes:
image

Header, mobile, with unsaved changes and long truncated title:
image

Testing

Steps:

  1. Open any product.
  2. Try out each of the above-listed changes in the header. Try testing in different environments and screen sizes, with long and short titles/UUIDs, etc.

This change is Reviewable

@gordlin gordlin added PR: Active PRs that require a fierce eyeballin. PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. labels Jan 17, 2025
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/new-header-bar-alter

@gordlin gordlin force-pushed the new-header-bar-alter branch from 09e9aaf to af9b5df Compare January 17, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Active PRs that require a fierce eyeballin. PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant