-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add react tools #11
feat(react): add react tools #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
добавь плиз ссылки на пакеты в общий readme и в конфиг size limit
packages/use-is-visible/index.ts
Outdated
return () => { | ||
observer.disconnect() | ||
} | ||
}, [element]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нужно добавить options в зависимости
"sideEffects": false, | ||
"publishConfig": { | ||
"access": "public" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нужно добавить react в peerDependencies
## Install | ||
|
||
``` | ||
npm install -D @rambler-tech/use-is-visible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
опечатка, нужно use-transition-visible. и для yarn add тоже
"sideEffects": false, | ||
"publishConfig": { | ||
"access": "public" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нужно добавить react в peerDependencies
d2f84e7
into
rambler-digital-solutions:master
No description provided.