Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add react tools #11

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

yurikochergin
Copy link
Contributor

No description provided.

Copy link
Member

@andrepolischuk andrepolischuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавь плиз ссылки на пакеты в общий readme и в конфиг size limit

return () => {
observer.disconnect()
}
}, [element])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно добавить options в зависимости

"sideEffects": false,
"publishConfig": {
"access": "public"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно добавить react в peerDependencies

## Install

```
npm install -D @rambler-tech/use-is-visible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

опечатка, нужно use-transition-visible. и для yarn add тоже

"sideEffects": false,
"publishConfig": {
"access": "public"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно добавить react в peerDependencies

@andrepolischuk andrepolischuk merged commit d2f84e7 into rambler-digital-solutions:master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants