-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINI-6478] Implement the interface miniAppFinishedLoading() to notify host app. #295
[MINI-6478] Implement the interface miniAppFinishedLoading() to notify host app. #295
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 74.66% 74.29% -0.37%
==========================================
Files 29 29
Lines 884 891 +7
Branches 66 66
==========================================
+ Hits 660 662 +2
- Misses 199 204 +5
Partials 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. Only one small change. Also, please update ReadMe & Changelog for the same
Co-authored-by: leojoseph.r <[email protected]>
I have updated the change log and read me for the SDK. |
Fixed sonar cloud code smells.
Quality Gate passedIssues Measures |
Description
Implement the interface miniAppFinishedLoading() in the MiniApp JS SDK and js bridge.
This method should be used my the miniapps to notify the host app after it has finished loading.
Links:
https://jira.rakuten-it.com/jira/browse/MINI-6478
Checklist