Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINI-6478] Implement the interface miniAppFinishedLoading() to notify host app. #295

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

GondiTilak
Copy link
Contributor

@GondiTilak GondiTilak commented Mar 7, 2024

Description

Implement the interface miniAppFinishedLoading() in the MiniApp JS SDK and js bridge.
This method should be used my the miniapps to notify the host app after it has finished loading.

Links:

https://jira.rakuten-it.com/jira/browse/MINI-6478

Checklist

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.29%. Comparing base (8d5bbc7) to head (88382a9).

Files Patch % Lines
js-miniapp-bridge/src/common-bridge.ts 20.00% 4 Missing ⚠️
js-miniapp-sdk/src/modules/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   74.66%   74.29%   -0.37%     
==========================================
  Files          29       29              
  Lines         884      891       +7     
  Branches       66       66              
==========================================
+ Hits          660      662       +2     
- Misses        199      204       +5     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rleojoseph rleojoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Only one small change. Also, please update ReadMe & Changelog for the same

js-miniapp-bridge/src/common-bridge.ts Outdated Show resolved Hide resolved
@GondiTilak
Copy link
Contributor Author

Looks ok to me. Only one small change. Also, please update ReadMe & Changelog for the same

I have updated the change log and read me for the SDK.

js-miniapp-bridge/src/common-bridge.ts Outdated Show resolved Hide resolved
js-miniapp-sample/src/pages/landing.js Outdated Show resolved Hide resolved
js-miniapp-sdk/README.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
16.4% Duplication on New Code

See analysis details on SonarCloud

@GondiTilak GondiTilak merged commit 71f55c7 into rakutentech:master Mar 11, 2024
7 checks passed
@GondiTilak GondiTilak changed the title [MiniAppSDK][JS] Implement the interface miniAppFinishedLoading() to notify host app. [MINI-6487] Implement the interface miniAppFinishedLoading() to notify host app. Mar 13, 2024
@GondiTilak GondiTilak changed the title [MINI-6487] Implement the interface miniAppFinishedLoading() to notify host app. [MINI-6478] Implement the interface miniAppFinishedLoading() to notify host app. Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants