Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MALI-1357] Manage special characters transmitted to the MiniApp #279

Merged

Conversation

rleojoseph
Copy link
Collaborator

Description

Describe the changes in this pull request.
Explain your rationale of technical decisions you made (unless discussed before).

Links

Add links to github/jira issues, design documents and other relevant resources (e.g. previous discussions, platform/tool documentation etc.)

Checklist

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #279 (6eb5542) into master (ca9dc01) will decrease coverage by 1.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   82.17%   81.15%   -1.02%     
==========================================
  Files          24       24              
  Lines         718      727       +9     
  Branches       55       57       +2     
==========================================
  Hits          590      590              
- Misses        108      117       +9     
  Partials       20       20              
Files Coverage Δ
js-miniapp-bridge/src/common-bridge.ts 71.18% <0.00%> (-2.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@munir-rakuten munir-rakuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rleojoseph rleojoseph merged commit ce20594 into rakutentech:master Oct 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants