Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MALI-1358] Fix for android Unicode issue #275

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

rleojoseph
Copy link
Collaborator

Description

Describe the changes in this pull request.
Explain your rationale of technical decisions you made (unless discussed before).

Links

Add links to github/jira issues, design documents and other relevant resources (e.g. previous discussions, platform/tool documentation etc.)

Checklist

Copy link
Contributor

@munir-rakuten munir-rakuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #275 (2087551) into master (712babd) will decrease coverage by 0.28%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   82.44%   82.17%   -0.28%     
==========================================
  Files          24       24              
  Lines         712      718       +6     
  Branches       54       55       +1     
==========================================
+ Hits          587      590       +3     
- Misses        106      108       +2     
- Partials       19       20       +1     
Files Coverage Δ
js-miniapp-bridge/src/common-bridge.ts 73.42% <57.14%> (-0.51%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rleojoseph rleojoseph merged commit b0574dd into rakutentech:master Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants